-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segfault in 1.10 while loading a package, possibly related to @recompile_invalidations #52660
Comments
Benjamin Lorenz started to take a look in the #helpdesk channel on slack, and had the below comments: Benjamin Lorenz Benjamin Lorenz |
One way of debugging is to build Julia 1.10 with assertions and see if one triggers. |
I got this assertion with a fresh julia 1.10 build:
Full output:
Edit:
I needed to pin |
Benjamin, do you think I should put this as an issue in PrecompileTools? Your workaround (taking all of the using statements out the @recompile_invalidations block) makes it seem like an issue there. |
Sounded a bit like a duplicate of #52435. But applying the fix for that wasn't sufficient for me diff --git a/src/staticdata.c b/src/staticdata.c
index f08b59828d..29e5d0eea3 100644
--- a/src/staticdata.c
+++ b/src/staticdata.c
@@ -643,7 +643,7 @@ static int jl_needs_serialization(jl_serializer_state *s, jl_value_t *v) JL_NOTS
else if (jl_typetagis(v, jl_uint8_tag << 4)) {
return 0;
}
- else if (jl_typetagis(v, jl_task_tag << 4)) {
+ else if (v == (jl_value_t*)s->ptls->root_task) {
return 0;
}
|
MWE:
apparently we forgot to exercise this case, since while I thought we had written the code to handle it, I apparently hadn't |
@vtjnash : 2 questions
|
I have a standalone MWE, so make any changes you want now and it won't mess that up |
Handle any sort of cycle encountered in the datatype super fields by always deferring that field until later and setting a deferred mechanism for updating the field only after the supertype is ready. Fix #52660
Handle any sort of cycle encountered in the datatype super fields by always deferring that field until later and setting a deferred mechanism for updating the field only after the supertype is ready. Fix #52660
Handle any sort of cycle encountered in the datatype super fields by always deferring that field until later and setting a deferred mechanism for updating the field only after the supertype is ready. Fix JuliaLang#52660 (cherry picked from commit c94b1a3)
The development version of ParameterEstimation.jl causes a segfault in Julia 1.10, but not 1.9.4.
MWE:
The final line causes a segfault. Here is the output:
I'm on WSL, using Ubuntu 22 on Windows 11. Versioninfo() returns the below. Julia was installed via Juliaup.
The text was updated successfully, but these errors were encountered: