-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alias analysis sometimes too strict for SubArrays #54621
Labels
Comments
fredrikekre
pushed a commit
that referenced
this issue
Jun 5, 2024
This avoids returning false positives where only the indices are shared. As the indices are not mutated by array assignments (and are explicitly warned against mutation in general), we can ignore the case where _only_ the indices are aliasing. Fix #54621
Thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi everyone,
I hit some very weird corner case where I create views on vectors where the index set is a vector. This causes some troubles for alias analysis. A minimal example which should be efficient to perform due to the shared index set is to copy the values from one subvector to another one.
I discovered this on Julia 1.10, but from going down the call graph I also assume that it is reproducible with older versions too, because it can be tracked down to mightalias returning true for the first case.
The text was updated successfully, but these errors were encountered: