Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JET linting error from wrap on Array (on 1.11) #54900

Closed
KristofferC opened this issue Jun 23, 2024 · 3 comments
Closed

JET linting error from wrap on Array (on 1.11) #54900

KristofferC opened this issue Jun 23, 2024 · 3 comments
Labels
arrays [a, r, r, a, y, s]

Comments

@KristofferC
Copy link
Member

KristofferC commented Jun 23, 2024

Seeing this in some PkgEval logs

  ││││││││┌ string(::String, ::Tuple{Base.OneTo{Int64}}, ::String, ::Tuple{Base.OneTo{Int64}}) @ Base ./strings/io.jl:189
  │││││││││┌ print_to_string(::String, ::Tuple{Base.OneTo{Int64}}, ::String, ::Tuple{Base.OneTo{Int64}}) @ Base ./strings/io.jl:150
  ││││││││││┌ _unsafe_take!(io::IOBuffer) @ Base ./iobuffer.jl:504
  │││││││││││┌ wrap(::Type{Array}, m::MemoryRef{UInt8}, l::Int64) @ Base ./array.jl:3099
  ││││││││││││ failed to optimize due to recursion: Base.wrap(::Type{Array}, ::MemoryRef{UInt8}, ::Int64)

Nut sure if it is benign. cc @aviatesk

See for example https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/cf4f1ba_vs_edb3c92/NonuniformFFTs.primary.log

@nsajko
Copy link
Contributor

nsajko commented Jun 23, 2024

wrap doesn't exist any more: #53896

@nsajko nsajko added the arrays [a, r, r, a, y, s] label Jun 23, 2024
@KristofferC
Copy link
Member Author

#54768 (comment)

@KristofferC KristofferC changed the title JET linting error from wrap on Array JET linting error from wrap on Array (on 1.11) Jun 23, 2024
@aviatesk
Copy link
Member

Reduced to:

ulia> report_opt(string, (String,Tuple{Base.OneTo{Int}},String,Tuple{Base.OneTo{Int}}))
═════ 4 possible errors found ═════
┌ string(::String, ::Tuple{Base.OneTo{Int64}}, ::String, ::Tuple{Base.OneTo{Int64}}) @ Base ./strings/io.jl:189
│┌ print_to_string(::String, ::Tuple{Base.OneTo{Int64}}, ::String, ::Tuple{Base.OneTo{Int64}}) @ Base ./strings/io.jl:150
││┌ _unsafe_take!(io::IOBuffer) @ Base ./iobuffer.jl:504
│││┌ wrap(::Type{Array}, m::MemoryRef{UInt8}, l::Int64) @ Base ./array.jl:3099
││││ failed to optimize due to recursion: Base.wrap(::Type{Array}, ::MemoryRef{UInt8}, ::Int64)
│││└────────────────────
││┌ print_to_string(::String, ::Int64, ::String, ::Vararg{Any}) @ Base ./strings/io.jl:143
│││ runtime dispatch detected: Base._str_sizehint(%17::Any)::Int64
││└────────────────────
││┌ print_to_string(::String, ::Int64, ::String, ::Vararg{Any}) @ Base ./strings/io.jl:148
│││ runtime dispatch detected: print(%59::IOBuffer, %97::Any)::Any
││└────────────────────
││┌ string(::String, ::Int64, ::String, ::Tuple{Int64}, ::String, ::Int64, ::String, ::Int64, ::String) @ Base ./strings/io.jl:189
│││ failed to optimize due to recursion: string(::String, ::Int64, ::String, ::Tuple{Int64}, ::String, ::Int64, ::String, ::Int64, ::String)
││└────────────────────

I will look into it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrays [a, r, r, a, y, s]
Projects
None yet
Development

No branches or pull requests

3 participants