Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JuliaSyntaxHighlighting from 1.11 #55023

Closed
LilithHafner opened this issue Jul 4, 2024 · 4 comments
Closed

Remove JuliaSyntaxHighlighting from 1.11 #55023

LilithHafner opened this issue Jul 4, 2024 · 4 comments
Labels
excision Removal of code from Base or the repository
Milestone

Comments

@LilithHafner
Copy link
Member

From a chat with @tecosaur at triage, Markdown uses it as of 1.12, but noting uses it in 1.11, and it is not quite ready for stdlibification. Notably, it has no docs and is still doing breaking changes (e.g. JuliaLang/JuliaSyntaxHighlighting.jl#2).

Still very much on board with having this functionality, just not in a stdlib in 1.11.

@LilithHafner LilithHafner added this to the 1.11 milestone Jul 4, 2024
@KristofferC
Copy link
Member

If nothing uses it in 1.11 it definitely makes sense to pull it.

@tecosaur
Copy link
Contributor

tecosaur commented Jul 4, 2024

Mmm, I think it makes sense to have for other stdlibs to use (as mentioned Markdown in 1.12, and some other future uses come to mind), but this didn't start happening in time for the 1.11 merge window.

So, I'm fully in support of pulling it from the 1.11 release.

@Keno
Copy link
Member

Keno commented Jul 4, 2024

Probably a separate issue, but the pull in should also be conditional on JuliaSyntax actually being in the system image. As of right now, the flisp parser is still supported and things shouldn't error if JuliaSyntax is not available. Probably the easiest way to accomplish this is to just have JuliaSyntaxHighlighting's exported API be a no-op if JuliaSyntax is unavailable.

@tecosaur
Copy link
Contributor

tecosaur commented Jul 21, 2024

Probably the easiest way to accomplish this is to just have JuliaSyntaxHighlighting's exported API be a no-op if JuliaSyntax is unavailable.

@Keno I'll happily make this change if somebody could let me know what a good way to check if JuliaSyntax is available is 🙂 (is a @static if isdefined(Base, :JuliaSyntax) fine?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
excision Removal of code from Base or the repository
Projects
None yet
Development

No branches or pull requests

5 participants