-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace magic constant test for linear solve on triangular matrices #5726
Conversation
This passes all tests on OSX with |
After running the test and subsequently commenting out lines 52, 54, 69, 156, 522, 523 etc.
the test still fail. This is unrelated to your change but there is no point to proceed further testing on 32 bit with matrices that close to singularity. |
Anyway, I gave it a last try: No specific 32 bit issues with your PR. 👍 |
- New export `condskeel` - Documentation with mathematical definition - Other minor documentation fixes to linalg
- Add automatic promotion of integers to floats for condskeel - Ref. #5605, #5705
Replace magic constant test for linear solve on triangular matrices
Thanks for cross-checking. |
condskeel(A::AbstractMatrix, p::Real=Inf) = norm(abs(inv(A))*abs(A), p) | ||
condskeel{T<:Integer}(A::AbstractMatrix{T}, p::Real=Inf) = norm(abs(inv(float(A)))*abs(A), p) | ||
condskeel(A::AbstractMatrix, x::AbstractVector, p::Real=Inf) = norm(abs(inv(A))*abs(A)*abs(x), p) | ||
condskeel{T<:Integer}(A::AbstractMatrix{T}, x::AbstractVector, p::Real=Inf) = norm(abs(inv(float(A)))*abs(A)*abs(x), p) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @Sacha0
condskeel