Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One more relaxation of test bounds in linalg. #5705

Merged
merged 1 commit into from
Feb 6, 2014

Conversation

mschauer
Copy link
Contributor

@mschauer mschauer commented Feb 6, 2014

(amends #5691, it still failed with 32 bit.)

@stevengj
Copy link
Member

stevengj commented Feb 6, 2014

It just seems like asking for trouble do linear-algebra tests with a random 10x10 matrix (a = rand(n,n)). There is some probability that the matrix will be badly conditioned enough to fail any test with any reasonable error threshold.

Why not just use a deterministic matrix instead? e.g. a = [exp(cos(i + 2*sin(j)))*(i-j)+sin(i*j) for i = 1:n, j=1:n] is not too badly conditioned for n=10.

@mschauer
Copy link
Contributor Author

mschauer commented Feb 6, 2014

Part of the problem is that when the magic numbers are chosen travis does not test on 32 bit, see travis-ci/travis-ci/issues/986, part of the problem is #5549 .

@jiahao
Copy link
Member

jiahao commented Feb 6, 2014

Please help cross-reference #5605 on such changes.

jiahao added a commit that referenced this pull request Feb 6, 2014
One more relaxation of test bounds in linalg.
@jiahao jiahao merged commit c1e2a69 into JuliaLang:master Feb 6, 2014
@jiahao
Copy link
Member

jiahao commented Feb 6, 2014

I'll accept this change but all this magic number nonsense just needs to go away.

@mschauer mschauer deleted the linalg branch February 6, 2014 22:53
jiahao added a commit that referenced this pull request Feb 8, 2014
- Add automatic promotion of integers to floats for condskeel
- Ref. #5605, #5705
jiahao added a commit that referenced this pull request Feb 8, 2014
- Add automatic promotion of integers to floats for condskeel
- Ref. #5605, #5705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants