Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename external/ to deps/ ? #726

Closed
nolta opened this issue Apr 16, 2012 · 16 comments
Closed

rename external/ to deps/ ? #726

nolta opened this issue Apr 16, 2012 · 16 comments
Labels
building Build system, or building Julia or its dependencies needs decision A decision on this change is needed

Comments

@nolta
Copy link
Member

nolta commented Apr 16, 2012

Checking other code into your git repo is a common practice. But this often inflates your project's language stats and may even cause your project to be labeled as another language. We are able to identify some of these files and directories and exclude them.

https://github.com/github/linguist/blob/master/lib/linguist/vendor.yml

@Keno
Copy link
Member

Keno commented Apr 16, 2012

How about deps instead?

@StefanKarpinski
Copy link
Member

I guess vendor is kind of a standard name, but I've never really cared for it. Other than mild distaste for the term, I guess I'm fine with renaming external to vendor.

@JeffBezanson
Copy link
Member

deps seems better. There doesn't seem to be any vending going on.

@ViralBShah
Copy link
Member

I prefer deps too.

@StefanKarpinski
Copy link
Member

Ok, I'm going to attempt this change. Keep your hats on, gentlemen.

@nolta
Copy link
Member Author

nolta commented Apr 18, 2012

After making this change, our stats will be:

44%  Julia
25%  C
13%  C++
8%   JavaScript
6%   Scheme
2%   Common Lisp
1%   Elixir

@StefanKarpinski
Copy link
Member

Unfortunately, there's too much crap in external that has absolute paths hardwired into it when you compile. It's forced me to rebuild everything, which is taking forever. I'm considering just making external a symlink to deps for a while to keep people from having to rebuild everything, but I guess that's just delaying the annoyance. Maybe someone can figure out a script of commands to fix everything in deps so that it works in the new location without recompiling...

@nolta
Copy link
Member Author

nolta commented Apr 18, 2012

Plan B: github-linguist/linguist#159

@JeffBezanson
Copy link
Member

That is too funny. I like your style :)
Is there such a thing as a .github file we can include, or is that not yet a real feature of linguist?

@StefanKarpinski
Copy link
Member

LOLOLOL. I love it :-)

@StefanKarpinski
Copy link
Member

This patch does the rename: https://gist.github.com/7583978a8852b2a4a3bd. However, I'm hesitant to screw over anyone who just compiled everything from scratch today and then has to do it again. Probably not an insignificant number of people given the slashdotting of my infoworld interview. I could make external a symlink for now, or just hold off on this change for a while. What do people think?

@JeffBezanson
Copy link
Member

I'd wait to see if there's some other magic we can do, like .github. Even if it requires features (hopefully not julia-specific) to be added to linguist, that would be better than disturbing people over something fairly silly like this.

@StefanKarpinski
Copy link
Member

I do like the name deps better though.

@StefanKarpinski
Copy link
Member

Here's a branch that does this: https://github.com/JuliaLang/julia/tree/sk/rename-external-deps. Also available as a gist.

@ViralBShah
Copy link
Member

Do you think we should try merge this into local_blas as it stands now, or would it be simpler to just do it from scratch?

-viral

On 29-Apr-2012, at 11:05 PM, Stefan Karpinski wrote:

Here's a branch that does this: https://github.com/JuliaLang/julia/tree/sk/rename-external-deps. Also available as a gist.


Reply to this email directly or view it on GitHub:
#726 (comment)

@StefanKarpinski
Copy link
Member

I'm not sure. As soon as my local_blas stops compiling, I can try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies needs decision A decision on this change is needed
Projects
None yet
Development

No branches or pull requests

5 participants