Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chooseproc should start at worker #1 #8105

Closed
eschnett opened this issue Aug 23, 2014 · 1 comment
Closed

chooseproc should start at worker #1 #8105

eschnett opened this issue Aug 23, 2014 · 1 comment

Comments

@eschnett
Copy link
Contributor

@Spawn distributes work starting from process #3 (worker #2). While this is not an error, this seems to be due to an oversight in the function "chooseproc" in multi.jl.

chooseproc initializes the variable "nextidx" to 1, and later adds 1 when indexing the workers() array. I think nextidx should be initialized to 0 instead. Alternatively, the mod expression that ensures that nextidx is not larger than nworkers() could be replaced by an if statement that explicitly resets nextidx before using it.
@jakebolewski
Copy link
Member

@eschnett that is indeed a bug, can you submit a quick pull-request? BTW, welcome to Julia!

jakebolewski added a commit that referenced this issue Aug 25, 2014
@jakebolewski
fixes issue where worker 1 was never getting work allocated to it whe…
c38f5c6 
…n nprocs > 3 (see #8105)
jakebolewski added a commit that referenced this issue Aug 25, 2014
@jakebolewski
changes chooseproc behavior so that we start from master+1 pid
50dd995 
right now with addprocs(>3) we start allocating work to process
pid+2 before wrapping around.  This change just starts allocating work
to process 2 (worker 1) which should be more intuitive. See #8105.
@jakebolewski jakebolewski mentioned this issue Aug 25, 2014
Merged
jakebolewski added a commit that referenced this issue Aug 25, 2014
@jakebolewski
changes chooseproc behavior so that we start from master+1 pid
6065756 
right now with addprocs(>3) we start allocating work to process
pid 3 before wrapping around.  This change just starts allocating work
to process 2 (worker 1) which should be more intuitive. See #8105.
jakebolewski added a commit that referenced this issue Aug 26, 2014
@jakebolewski @staticfloat
changes chooseproc behavior so that we start from master+1 pid
d15396d 
right now with addprocs(>3) we start allocating work to process
pid 3 before wrapping around.  This change just starts allocating work
to process 2 (worker 1) which should be more intuitive. See #8105.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eschnett @JeffBezanson @jakebolewski