jl_errorf: null terminate buffer before printing #10112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed this when adding an entry to sysimg.jl that `include`s a file that does not exist. The resulting error message had extra characters due to a string that was not properly null terminated.
|
In principle the return value of each |
JeffBezanson
added a commit
that referenced
this pull request
Feb 7, 2015
jl_errorf: null terminate buffer before printing
|
somewhat related: #9450 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I noticed this issue when adding an entry to
sysimg.jlthatincludes a file that does not exist. The resulting error message had extra characters due to a string that was not properly null terminated.)