Faster and more general reductions for sparse matrices #10536
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hooks sparse matrix reductions into the
mapreduce
/mapreducedim
framework so that reductions based on those two functions (sum
,prod
,maximum
,minimum
,sumabs
,sumabs2
,maxabs
,minabs
, and others) are fast for sparse matrices. I also implemented a method ofcentralize_sumabs2!
, which is the function that computes the reduction forvar
andstd
. This required a tiny tweak tostatistics.jl
.Before:
After:
All times are after warmup.