Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing GC root #10738

Merged
merged 1 commit into from
Apr 23, 2015
Merged

Missing GC root #10738

merged 1 commit into from
Apr 23, 2015

Conversation

carnaval
Copy link
Contributor

@carnaval carnaval commented Apr 3, 2015

#10725 bearing fruits already.

I only did a quick sweep for usage of this function so I'll have another look before merging.

@timholy
Copy link
Member

timholy commented Apr 3, 2015

Really glad you're doing this. After reading through all the *.c files in #10275, I never got around to the *.cpp ones. And of course it's quite possible you'll catch ones I missed even in the parts I examined.

@JeffBezanson
Copy link
Member

Rebase please?

@carnaval
Copy link
Contributor Author

Sorry short attention span. Will do tomorrow.

@carnaval
Copy link
Contributor Author

Rebased. Waiting for make testall. I see you already fixed the one in n_fields codegen in the tuple merge.

@carnaval
Copy link
Contributor Author

Oh right, the ccall one also got fixed in the meantime. I'm not good at rebasing in the morning.

@carnaval
Copy link
Contributor Author

Is the 32bit failure the one from the tuple merge ? I'm going to have a look on a 32bit vm.

@tkelman
Copy link
Contributor

tkelman commented Apr 23, 2015

The failure was #10875, which is one of the new intermittent problems introduced by the tuple merge. Please do take a look if you get a chance.

@carnaval
Copy link
Contributor Author

Yeah it's hard to reproduce. I tried on a 32b VM and got the expected Vector{Any} got Vector{Any} stuff once but not in a deterministic way.
I dream of a day where every travis build would run under rr record and would open a ssh session automatically straight into gdb when it fails.

@tkelman
Copy link
Contributor

tkelman commented Apr 23, 2015

I dream of a day where every travis build would run under rr record and would open a ssh session automatically straight into gdb when it fails.

We should try at least the rr record part of this. We could gist a dump or something on failures. I recall @garrison was looking into rr recently, is there a PPA for Ubuntu Precise, or generic Linux binaries that could work?

JeffBezanson added a commit that referenced this pull request Apr 23, 2015
@JeffBezanson
Merge pull request #10738 from JuliaLang/ob/missingroot
7e63e6a 
Missing GC root
@JeffBezanson JeffBezanson merged commit 7e63e6a into master Apr 23, 2015
@garrison
Copy link
Member

Looks like lack of a PPA is an open bug in rr (rr-debugger/rr#26). Another thing to keep in mind is that we depend on syscall implementations that have not yet made it into a release and are only available on master. I wonder if we could convince the rr folks to do a release in the near future...

@garrison
Copy link
Member

Nevermind on the statement about the version. They actually did a release earlier today, and I hadn't checked since last night.

@tkelman tkelman deleted the ob/missingroot branch April 23, 2015 02:59
@garrison garrison mentioned this pull request Apr 23, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carnaval @timholy @JeffBezanson @tkelman @garrison