Build dsfmt with msvc #10775
Merged
Build dsfmt with msvc #10775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a def file for exported symbols to fix sysimg unknown function failure
|
A few more casts have snuck in on master. Also need to tag utf8proc at some point, and figure out whether it's possible to force 16-byte array alignment in MSVC... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets to an MSVC repl again, though it needs
an opena not-yet-tagged PR in utf8proc and a patch inbase/string.jlto avoid relying on 128-bit integers. ccalltest fails to build because MSVC doesn't support C99complex double, apparently not even in the 2015 prerelease.Previously
rand(1:2)would crash due to missing int128 intrinsics, but now it's failing this array-alignment assertion:julia/base/dSFMT.jl
Line 50 in e5f1e8d