Fix #10829, freeing of uninitialized pointer #10832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in 11a0f43 made the assumption that `handle->errmsg` would be initialized to NUL. This is true within julia itself, but BinDeps violates this assumption. The current commit changes things to fix the memory leak at its actual source, in `jl_load_dynamic_library_`.
|
This did not work for me on OSX 10.10.3 julia> Pkg.build("AudioIO")
...
julia(59826,0x7fff7d0f6300) malloc: *** error for object 0x7ffceb882ad0: pointer being freed was not allocated
*** set a breakpoint in malloc_error_break to debug
signal (6): Abort trap: 6
__pthread_kill at /usr/lib/system/libsystem_kernel.dylib (unknown line)
[1] 59826 abort julia |
|
Are you using BinDeps |
|
I wasn't on the latest master. Just pulled and it works now. |
|
LGTM, but I'd like a +1 from someone else. |
|
Fixes #10829 for me on linux when using BinDeps master. (update: OSX as well) |
ihnorton
added a commit
that referenced
this pull request
Apr 17, 2015
Fix #10829, freeing of uninitialized pointer
|
Thanks @garrison. |
This was referenced Apr 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in 11a0f43 made the assumption that
handle->errmsgwould be initialized to NUL. This is true within julia itself, but BinDeps violates this assumption. The current commit changes things to fix the memory leak at its actual source, injl_load_dynamic_library_.