Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the new signature of invoke #10939

Merged
merged 2 commits into from
May 3, 2015
Merged

Conversation

yuyichao
Copy link
Contributor

Replace all invoke(f, (...), ...) with invoke(f, Tuple{...}, ...)

If the CI fails, it's probably either a typo or a bug.

@tkelman
Copy link
Contributor

tkelman commented Apr 22, 2015

we should probably have at least one or two tests of the fallback syntax for the sake of packages

@yuyichao
Copy link
Contributor Author

@tkelman Done.

@tkelman
Copy link
Contributor

tkelman commented Apr 23, 2015

from 32 bit build on travis:

exception on 8: ERROR: LoadError: TypeError: subtype: expected Type{T}, got Ptr{Any}
 in issubstate at ./inference.jl:1138
 in schanged at ./inference.jl:1149
 in stchanged at ./inference.jl:1171
 in typeinf_uncached at ./inference.jl:1628
 in typeinf at ./inference.jl:1304
 in typeinf at ./inference.jl:1254
 in abstract_call_gf at ./inference.jl:693
 in abstract_call at ./inference.jl:820
 in abstract_eval_call at ./inference.jl:901
 in abstract_eval at ./inference.jl:928
 in typeinf_uncached at ./inference.jl:1588
 in typeinf at ./inference.jl:1304
 in typeinf_ext at ./inference.jl:1248
 in show_list at ./show.jl:354
 in show_unquoted at ./show.jl:557
 in print at show.jl:241
 in print_to_string at ./string.jl:24
 in string at string.jl:33
 in default_handler at test.jl:25
 in do_test at test.jl:50
 in runtests at /tmp/julia/share/julia/test/testdefs.jl:77
 in anonymous at multi.jl:836
 in run_work_thunk at multi.jl:587
 in anonymous at task.jl:836
while loading ccall.jl, in expression starting on line 26
    From worker 3:       * path                 in   1.38 seconds
fatal error on 8: ERROR: cannot serialize a pointer
 in serialize at serialize.jl:65
 in serialize at serialize.jl:334 (repeats 2 times)
 in send_msg_ at ./multi.jl:174
 in send_msg_now at multi.jl:144
 in send_msg_now at multi.jl:75
 in deliver_result at multi.jl:760
 in anonymous at task.jl:837
Worker 8 terminated.
    From worker 8:       * ccall               ERROR (unhandled task failure): EOFError: read end of file
 in yieldto at task.jl:19
 in wait at ./task.jl:307
 in wait at ./task.jl:223
 in wait_full at ./multi.jl:570
 in remotecall_fetch at multi.jl:670
 in remotecall_fetch at multi.jl:675
 in anonymous at task.jl:1386

oh my... no idea whether it's related to this PR or pre-existing on master though

@yuyichao yuyichao force-pushed the invoke-tuple branch 3 times, most recently from 026273a to 4ad6719 Compare April 25, 2015 16:44
@yuyichao
Copy link
Contributor Author

Ping

The failure seems to be disapeared after rebasing.......

Would be nice to have this so that the new signature can get more testing....

@yuyichao yuyichao force-pushed the invoke-tuple branch 4 times, most recently from d8bb380 to 9591396 Compare April 28, 2015 04:30
tkelman added a commit that referenced this pull request May 3, 2015
use the new signature of invoke
@tkelman tkelman merged commit 76927ce into JuliaLang:master May 3, 2015
@tkelman
Copy link
Contributor

tkelman commented May 3, 2015

This was the only one of your open PR's I felt remotely qualified to hit merge on. There are some really nasty bugs on 32 bit right now but I'm pretty sure this change can't make them any worse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants