-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use the new signature of invoke #10939
Conversation
we should probably have at least one or two tests of the fallback syntax for the sake of packages |
@tkelman Done. |
from 32 bit build on travis:
oh my... no idea whether it's related to this PR or pre-existing on master though |
026273a
to
4ad6719
Compare
Ping The failure seems to be disapeared after rebasing....... Would be nice to have this so that the new signature can get more testing.... |
d8bb380
to
9591396
Compare
use the new signature of invoke
This was the only one of your open PR's I felt remotely qualified to hit merge on. There are some really nasty bugs on 32 bit right now but I'm pretty sure this change can't make them any worse. |
Replace all
invoke(f, (...), ...)
withinvoke(f, Tuple{...}, ...)
If the CI fails, it's probably either a typo or a bug.