-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing operations for LinSpace. Fix #11049 #11233
Conversation
Hmmm? The CI fails far before it reaches anything I changed when trying to get a version number?? |
Actually I think I need to handle the case when |
|
LGTM. I'm a little confused why both LinSpace and FloatRange exist now and aren't quite the same thing, but if we're going to have both, may as well have things tested and functioning. |
Wooah yeah, I missed when LinSpace was a type, thats kinda funky |
Well, yeah, that's the same question I asked in #11049. It seems that they are using slightly different algorithms so in corner cases they may produce slightly different results (and IMHO the linspace one is better for small steps). |
Background is #9666, #9637, but I didn't follow this in detail. @StefanKarpinski, since this is your domain it would be best if you reviewed this. |
(But it all LGTM.) |
Yeah, seems right. Sorry about missing these. I'm still not fully convinced about this change, but since we currently have it, may as well have the more complete version. |
Missing operations for LinSpace. Fix #11049
Make it as closed to
FloatRange
as possible. Hopefully I'm using the right algorithm....The divided by 0 case is a little different from
FloatRange
IMHO both are wrong because
But I'm waiting to see what ppl think...