Only allow $ as prefix operator in export and import and do not look across newlines #11495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…across newlines. Fix up JuliaLang#11338
|
P.S. would a slightly more polished version of the |
This was referenced May 30, 2015
|
Hey this I reproduced it locally but still have no idea what's wrong..... |
|
Ok I guess we don't need this now, but it would still be good to have the tests. |
|
@JeffBezanson I guess you mean the original issue is already fixed by #11497 . I'll submit a PR for the test for both then (unless it is already done). Do you think a |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix up #11338
@JeffBezanson The test cases added should work now.
Another difference caused by this PR is that
using &awill be parsed as(:call :* (:using :&), :a)instead of a parse error now. This is the same behavior before #11338, has always been the case forusing -a, and will be caught by further lowering so it shouldn't be a problem. (Althoughexpanddoesn't complain about it and I'm not sure how to add a test for that...)