alloca & callconv fixes #11644
Merged
alloca & callconv fixes #11644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is fantastic. Great work, Jameson! |
vtjnash
force-pushed
the
jn/fix_alloca_callconv
branch
4 times, most recently
from
9aa838f
to
3add3c5
Compare
|
the win32 test was broken because llvm33 incorrectly orders a |
fix #11187 (pass struct and tuple objects by stack pointer) fix #11450 (ccall emission was frobbing the stack) likely may fix #11026 and may fix #11003 (ref #10525) invalid stack-read on 32-bit this additionally changes the julia specSig calling convention to pass non-primitive types by pointer instead of by-value this additionally fixes a bug in gen_cfunction that could be exposed by turning off specSig this additionally moves the alloca calls in ccall (and other places) to the entry BasicBlock in the function, ensuring that llvm detects them as static allocations and moves them into the function prologue this additionally fixes some undefined behavior from changing a variable's size through a alloca-cast instead of zext/sext/trunc this additionally prepares for turning back on allocating tuples as vectors, since the gc now guarantees 16-byte alignment future work this makes possible: - create a function to replace the jlallocobj_func+init_bits_value call pair (to reduce codegen pressure) - allow moving pointers sometimes rather than always copying immutable data - teach the GC how it can re-use an existing pointer as a box
…a (16 byte) and C (assume 1 byte) as needed
vtjnash
force-pushed
the
jn/fix_alloca_callconv
branch
from
3add3c5
to
754bad4
Compare
|
CI seems (mostly) happy now, so I'll merge this in the morning. then we can start to check whether it has successfully taken care of all of the invalid stack reads or if any still remain. |
|
Looks like the ccall test failed on 32-bit travis? |
|
fooey, i think i merged the wrong version of this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Keno and @JeffBezanson for your awareness, see the commit description for all of the things that this modifies
(i couldn't get the Vector case working -- it corrupts the
functionaltest if you are interested in trying to find the alignment bug yourself -- so i turned it back off)