Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Add an interfaces manual chapter #11794

Merged
merged 5 commits into from
Jul 20, 2015
Merged

RFC: Add an interfaces manual chapter #11794

merged 5 commits into from
Jul 20, 2015

Commits on Jun 21, 2015

  1. Add an interfaces manual chapter 

    Document the iterable, indexable, and abstract array interfaces.

[av skip]
    @mbauman
    mbauman committed Jun 21, 2015
    Configuration menu
    Copy the full SHA
    4223b58 View commit details
    Browse the repository at this point in the history

  2. Add doctests

    @mbauman
    mbauman committed Jun 21, 2015
    13 Configuration menu
    Copy the full SHA
    552cbd9 View commit details
    Browse the repository at this point in the history

  3. Update after review 

    * Use sequence instead of collection in some places
* Change eltype and length descriptions
* Indentation fixes
* Talk about how defining getindex manually is a game of whackamole without support from AbstractArray
* Link to Array Indexing section

[av skip]
    @mbauman
    mbauman committed Jun 21, 2015
    Configuration menu
    Copy the full SHA
    0174b52 View commit details
    Browse the repository at this point in the history

  4. Update after Milan's comments 

    * complicated -> rich
* fix linearindexing description coherence between phrases by changing the first part of the phrase
* add a paragraph about how linearindexing impacts which getindex method(s) must get defined
* Fix missing *what*
* each other

[av skip]
    @mbauman
    mbauman committed Jun 21, 2015
    Configuration menu
    Copy the full SHA
    c131150 View commit details
    Browse the repository at this point in the history

  5. More cross-links! 

    [av skip]
    @mbauman
    mbauman committed Jun 21, 2015
    Configuration menu
    Copy the full SHA
    dea117b View commit details
    Browse the repository at this point in the history