-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly define an Inf64 and NaN64 #11841
Conversation
There is no such thing as a "native" bit depth affinity for floating point like there are for integers. |
|
Then why are |
Introducing |
Yes, it seems reasonable to me too. In particular, it would be pathological for those names to mean anything else, so why not have them? They should also be exported here. |
Is there anything to show the quiet or signaling bit, sign bit, and payload of a |
Does |
That seems like a fairly easy question to get an answer to... |
Can you squash this into one commit? |
I keep forgetting, tone is lost on the Internet! I really meant, "shouldn't they be identical?" |
lgtm, should merge as long as travis is green. AppVeyor has a backlog in the queue, and is likely to fail right now anyway due to #11818, so not 100% necessary to wait for it here. |
Two values are julia> typeof(Inf)
Float64
julia> typeof(Inf16)
Float16 |
OK... another fun thing: why does julia give different bitpatterns than C/C++ for NaNs? |
Not sure what C/C++ is doing, but we're just calling the |
Explicitly define an Inf64 and NaN64
Currently we have 32-bit version of Inf and NaN (
Inf32
andNaN32
) but regularInf
andNaN
are assumed 64-bit. This fix creates an explicitNaN64
andInf64
withNaN
andInf
being set to the appropriate type, in the style ofInt
etc.