Allow sys.ji to not exist during make install
#11854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the current rules will fail without a |
|
Yeah I think we should not be putting the .o in the installed copy (#11640 (comment)). We need .ji iff we need a backup option for running without a dylib. Basically only for coverage, or windows until we upgrade llvm. |
|
Windows failure unrelated. I'm going to merge this as, even though it may not be the perfect fix, it does work, and is very unlikely to break anything. Let me know if there's a better one. |
staticfloat
added a commit
that referenced
this pull request
Jun 26, 2015
Allow sys.ji to not exist during `make install`
|
This is good enough for now I think, there is a need to get updated nightlies out. I wonder why Travis didn't hit this, doesn't it do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JeffBezanson does this look like the right fix for #11640 (comment)?