Fix dump(io) and xdump(io), add tests #12072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebolewski
added a commit
that referenced
this pull request
Jul 9, 2015
Fix dump(io) and xdump(io), add tests
| @@ -269,3 +269,12 @@ end | |||
| @test_repr "bitstype 100 B" | |||
| @test repr(:(bitstype A B)) == ":(bitstype A B)" | |||
| @test repr(:(bitstype 100 B)) == ":(bitstype 100 B)" | |||
|
|
|||
| oldout = STDOUT | |||
There was a problem hiding this comment.
Should be in let block and I don't think the try block or even the @test is necessary.
There was a problem hiding this comment.
I understand about the let block, but shouldn't it have the @test to make sure that it returns as expected?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug I ran across when trying to debug some issues with output.
dump and xdump were both defined with (x)dump(args...) and (x)dump(io::IO, args...),
so that (x)dump of a single argument of type <: IO would get an error.
Fixed by adding two methods: (x)dump(arg::IO) = xdump((x)dump,STDOUT::IO,arg)