Remove OVERLAP_SVEC_LEN #12288
Merged
Remove OVERLAP_SVEC_LEN #12288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
agreed, there is little point keeping broken code around, maybe only for nostalgia but there is the whole git history for that. I hope that |
|
My impression was that it was useful when it was still |
|
well, useful maybe but did anyone ever build it that way ? Given that we find bugs in the default set of option all the time, I would be quite surprised if a change to the internal representation like that, almost never tested, was even barely functioning. Maybe I'm just pessimistic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently no one have ever tried it after #10380 because it has been broken since then.
I think we also don't need this risky saving anymore since we don't use
SimpleVectorall over the place anymore and only for certain internal stuff.