More tests for float functions and some small tests elsewhere #12318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
test
|
Gah! This passed locally. I will fix + update. e: there we go! |
| @@ -90,7 +90,8 @@ end | |||
| @test isapprox(.1+.1+.1, .3) | |||
| @test !isapprox(.1+.1+.1, .4) | |||
|
|
|||
| @test_throws UndefVarError test_approx_eq(ones(10),ones(11),1e-8,"a","b") | |||
| @test_throws UndefVarError test_approx_eq(ones(10),zeros(10),1e-8,"a","b") | |||
There was a problem hiding this comment.
how are these UndefVarErrors?
ah, I think this needs to be Test.test_approx_eq
There was a problem hiding this comment.
They are throwing a generic error("stuff"). I thought the correct thing was UnderVarError but maybe it should be ErrorException instead?
There was a problem hiding this comment.
Generic error throws an ErrorException, this is throwing UndefVarError because it isn't qualified as Test.test_approx_eq
There was a problem hiding this comment.
Oh no!!! I'm sorry. I'll fix it. Thanks for catching this and reviewing my bad PRs :)
|
lgtm |
kshyatt
added a commit
that referenced
this pull request
Jul 27, 2015
More tests for float functions and some small tests elsewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of
floatfuncs.jlwas not tested so I made a new file for it.reduce.jlandtest.jlhad small throws/paths that weren't tested, added tests for those.Added tests for the environment variable functions in
rounding.jlwhich weren't tested fully.