Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: re-export localindexes [ci skip] #12423

Closed
wants to merge 1 commit into from
Closed

Conversation

timholy
Copy link
Member

@timholy timholy commented Aug 1, 2015

@tkelman
Copy link
Contributor

tkelman commented Aug 1, 2015

removing too many exports isn't necessarily a bad thing...

@timholy
Copy link
Member Author

timholy commented Aug 1, 2015

Sure, if we want to leave this un-exported, that would be fine. But since it seems to have been an accident, I thought I'd raise it for discussion. CC @amitmurthy.

@amitmurthy
Copy link
Contributor

I am for re-exporting, now that SharedArrays are not being marked as experimental and because this is a useful api for work partitioning.

@timholy
Copy link
Member Author

timholy commented Aug 3, 2015

@one-more-minute, I just rebased this attempting to work with the new documentation system. (The "Blah blah" part of this commit is obviously something I might have to reevaluate, so consider this a WIP 😄.)

Unfortunately, after make && make -C doc html I get this:

help?> localindexes
search: localindexes


julia>

and this:
image

Can you provide a bit more guidance about how we're supposed to proceed? I've read both http://docs.julialang.org/en/latest/manual/documentation/ and https://groups.google.com/d/msg/julia-users/eI-mZe2zA-c/kmc7RdPPAQAJ, is there some other place I should be looking?

@MikeInnes
Copy link
Member

Not sure if the doc stuff will run as part of make, but you can force it with julia doc/genstdlib.jl. The other thing to be wary of is that we don't completely support documenting things before the doc system is loaded, which looks like it might be the case here, so you could try putting the docstring in base/docs/basedocs.jl to see if that helps.

@timholy
Copy link
Member Author

timholy commented Aug 3, 2015

Moving to base/docs/basedocs.jl made ?localindexes work, thanks!

But no dice on the RST documentation (still "Blah blah"). I did this order:

make
./julia doc/genstdlib.jl
make -C doc html
firefox doc/_build/html/index.html &

@MikeInnes
Copy link
Member

Ah, I forgot – since your docstring is in Markdown it needs #12435 in order to output to RST. If you leave it as it is I'll make sure that gets fixed as part of that PR.

@tkelman
Copy link
Contributor

tkelman commented Aug 3, 2015

Would it help to just push the RST rendering backend part of that PR (and a test) to master? Rendering currently-markdown docstrings into RST is something people are going to want to do now, but converting all of the RST in helpdb into markdown might take a while to get totally right.

@MikeInnes
Copy link
Member

Yeah, that makes sense, I went ahead and pushed that commit, so that should make things easier for this PR.

@timholy
Copy link
Member Author

timholy commented Aug 3, 2015

I rebased on top of aff076d, but without moving the docstring to base/docs/basedocs.jl, I'm still not getting anything for either version (REPL or RST docs). Should I just leave this here and let you play with it?

@@ -703,6 +703,10 @@ Shared Arrays (Experimental, UNIX-only feature)
Returns the index of the current worker into the ``pids`` vector, i.e., the list of workers mapping
the SharedArray

.. function:: localindexes(S::SharedArray)

Blah blah
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was me testing the new documentation system---see the history in #12423. This will not be part of the final commit.

@StefanKarpinski StefanKarpinski changed the title Re-export localindexes [ci skip] WIP: re-export localindexes [ci skip] Aug 12, 2015
@timholy
Copy link
Member Author

timholy commented Oct 29, 2015

Subsumed in 9c595c3

@timholy timholy closed this Oct 29, 2015
@timholy timholy deleted the teh/localindexes branch October 29, 2015 11:17
@tkelman
Copy link
Contributor

tkelman commented Oct 29, 2015

The doc addition for it wasn't though?

@timholy timholy restored the teh/localindexes branch October 29, 2015 13:15
@timholy timholy reopened this Oct 29, 2015
@timholy
Copy link
Member Author

timholy commented Oct 29, 2015

Good point. Leaving this open, short on time right now.

@timholy
Copy link
Member Author

timholy commented Jan 2, 2016

Superseded by #14532.

@timholy timholy closed this Jan 2, 2016
@timholy timholy deleted the teh/localindexes branch January 2, 2016 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants