Document methods after definition. #12496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -161,7 +161,7 @@ c,r,res = test_complete(s) | |||
|
|
|||
| s = "\\a" | |||
| c, r, res = test_complete(s) | |||
| "\\alpha" in c | |||
| ("\\alpha" in c) | |||
There was a problem hiding this comment.
Some how this line was being treated as a docstring... not sure what's up there.
There was a problem hiding this comment.
Sure, was trying to reduce to something reproducible. I'll open one shortly. (Edit: #12501)
|
cc @one-more-minute, @yuyichao. |
|
I would still prefer the quoted syntax since it can just be treated as documenting a value. It doesn't conflict with this though so we could support both. |
|
I'm fine with either really. This way was simpler to add, no special casing as with the macro version. |
|
LGTM |
This was referenced Aug 7, 2015
Closed
MichaelHatherly
force-pushed
the
mh/docmethods
branch
from
3cb5bf8 to
8ed9a39
Compare
MikeInnes
added a commit
that referenced
this pull request
Aug 10, 2015
Document methods after definition.
|
Nice work as always |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.