Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maxdepth and sortedby options to Profile.print (fixes #12510) #12516

Merged
merged 1 commit into from
Aug 10, 2015

Conversation

timholy
Copy link
Member

@timholy timholy commented Aug 8, 2015

timholy added a commit that referenced this pull request Aug 10, 2015
Add maxdepth and sortedby options to Profile.print (fixes #12510)
@timholy timholy merged commit 5c9d178 into master Aug 10, 2015
@timholy timholy deleted the teh/profile_printing branch August 10, 2015 19:21
@@ -211,7 +211,7 @@ Options for controlling the display of profile results
:func:`Profile.print` has more options than we've described so far.
Let's see the full declaration::

function print(io::IO = STDOUT, data = fetch(); format = :tree, C = false, combine = true, cols = tty_cols())
function print(io::IO = STDOUT, data = fetch(); format = :tree, C = false, combine = true, cols = tty_cols(), maxdepth = typemax(Int), sortedby = :filefuncline)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are entries for this in stdlib and helpdb too, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, but I'm not going to worry about that until the doc stuff settles out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what you mean by settles out. It's in an unfortunate state right now and other than better clarifications of how the current state is supposed to work I don't think it's going to change dramatically before 0.4, we just have to cope as best we can. Or decide to revert the conversion again since it's clearly confusing everyone.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just figure folks are busy, and it's a hard problem. I'm confident it will be sorted out soon enough.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump. Just got confused by the lack of maxdepth documentation at the repl.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already done, see #14532. Maybe needs a backport tag, though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right, memory fail. will see how conflict-messy the backport is for 0.4.3, which I should get started on soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants