Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention ++, per discussion at #11686 #12554

Merged
merged 1 commit into from
Aug 11, 2015

Conversation

waldyrious
Copy link
Contributor

No description provided.

StefanKarpinski added a commit that referenced this pull request Aug 11, 2015
@StefanKarpinski StefanKarpinski merged commit cceac50 into JuliaLang:master Aug 11, 2015
@tkelman
Copy link
Contributor

tkelman commented Aug 11, 2015

I'd rather not even mention string concatenation here at this point, and just say that packages are free to provide their own implementations for the ++ operator now.

@StefanKarpinski
Copy link
Member

This is the danger: people are going to start using ++ and then that code is going to break if Base defines a meaning for ++. That's why there was resistance to adding this note.

@waldyrious
Copy link
Contributor Author

While that's technically true, it can't be denied that the only reason this operator was added was in the sequence of that discussion. Pretending otherwise would be fooling ourselves IMO. In any case, I can't imagine Base implementing anything too different from string concatenation based on this operator (it wouldn't make sense given the history of discussions that led to its inclusion), so any potential breakage would be in implementation details, rather than entirely different functionality.

@waldyrious waldyrious deleted the patch-1 branch August 11, 2015 12:10
@quinnj
Copy link
Member

quinnj commented Aug 11, 2015

Yeah, I'm still not feeling the need to document this, I think it may lead to more trouble than it's worth.

@waldyrious
Copy link
Contributor Author

Update, for future reference: @JeffBezanson has removed the bit about string concatenation in 500ecf6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants