Add more testing for strings/types.jl and strings/search.jl #12877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whats with the commented out tests? Should probably have comments explaining why, whatever the reason, for the sake of future testers |
|
@IainNZ Those hopefully won't be there long (but I'll put an explanation in). Those are inconsistencies I discovered when writing the tests. I'll submit a PR to fix the inconsistencies, but that will have to be for 0.5-dev, while the coverage tests (at least those that can run currently) should be in 0.4. |
Add comments about commented out tests for inconsistencies that will need to be fixed post-0.4 in a subsequent PR
ScottPJones
force-pushed
the
spj/testtypes
branch
from
2ccf2ef to
115d34c
Compare
jakebolewski
added a commit
that referenced
this pull request
Sep 1, 2015
Add more testing for strings/types.jl and strings/search.jl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.