-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #13024, sparse & and | #13036
Fix #13024, sparse & and | #13036
Conversation
Can has $ while you're at it? |
also fix eltype promotion in sparse max and min Also add $ because Jiahao asked nicely
Sure. |
@@ -1,5 +1,7 @@ | |||
# This file is a part of Julia. License is MIT: http://julialang.org/license | |||
|
|||
using Base.Test | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just for running this as a script alone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, to make ./julia test/sparsedir/sparse.jl
work - should be harmless
Thank you both (all) so much for this. Efficient |
Fix #13024, sparse & and |
Sorry for the naive question, but what's the process for getting this into the 4.x branch? (Am I correct in assuming it won't make it into -release?) |
It didn't make it into RC1, but I'll probably backport it before RC2. This is slightly breaking if anyone were relying on the existing incorrect and slow output types, so my preference would be to at least let PackageEvaluator run with this in the nightlies before doing the backport. I'll write up a formal backporting policy when I get some time to do so. |
thanks very much for the explanation, and I'm thrilled to hear it might make it into -release. I don't know much about how backported features are tested with PackageEvaluator but if you need an extra set of eyes/hands and don't mind the occasional silly question I'm happy to help out. |
whoops, added the wrong # reference to the backport commit message here. backported in #13072 |
also fix eltype promotion in sparse max and min