-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually convert bulleted lists to Markdown #13046
Conversation
[ci skip]
argument must be a command. Strings refer to filenames. | ||
When called with more than two arguments, they are chained together from left to right. | ||
For example ``pipeline(a,b,c)`` is equivalent to ``pipeline(pipeline(a,b),c)``. This provides a more | ||
For example `pipeline(a,b,c)` is equivalent to `pipeline(pipeline(a,b),c)`. This provides a more | ||
concise way to specify multi-stage pipelines. | ||
|
||
**Examples**: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this rendered correctly with MarkDown?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, and it converts seamlessly back to RST, too. I think it's a GitHub flavor extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm running make -C doc
and checked the html doc, on master it looks like
While on this branch it looks like:
The new version doesn't look too bad (honestly I prefer the new version) but this seems to be sth that markdown doesn't fully support (and / or not taken care of by the conversion code) and can introduce inconsistency in the html doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could use a header instead, but I think it's fine (I thought you were talking about the nested `backticks
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look that bad.
Manually convert bulleted lists to Markdown
backported in #13072 |
Bullet lists work just fine in Markdown right now, but it looks like the auto-converter didn't convert some. So I just manually converted them as I was browsing through the helpdb.