Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct warning to io #13921

Merged
merged 1 commit into from
Nov 9, 2015
Merged

Direct warning to io #13921

merged 1 commit into from
Nov 9, 2015

Conversation

timholy
Copy link
Member

@timholy timholy commented Nov 8, 2015

@tkelman
Copy link
Contributor

tkelman commented Nov 8, 2015

i feel like there might also be a doctest that's related to this error

@timholy
Copy link
Member Author

timholy commented Nov 9, 2015

Not quite sure I follow---you mean something that's triggering the error that this is designed to circumvent?

@tkelman
Copy link
Contributor

tkelman commented Nov 9, 2015

No, I think one of the doctests triggers this or a very similar error, with the error output captured and some explanation nearby. I don't know whether other doctests are in a passing state on master right now so this might not be the fastest thing to find.

@timholy
Copy link
Member Author

timholy commented Nov 9, 2015

OK to merge, then?

@tkelman
Copy link
Contributor

tkelman commented Nov 9, 2015

yes, but should run the doctests because I suspect #13904 could have changed some tested-for outputs.

@timholy
Copy link
Member Author

timholy commented Nov 9, 2015

Now I get what you mean. Summary on this branch:

Doctest summary
===============
 1003 tests
   59 failures in tests
    0 failures in setup code
    0 failures in cleanup code

Master prior to #13904:

 1003 tests
   59 failures in tests
    0 failures in setup code
    0 failures in cleanup code

Seems like there's no regression, anyway.

Most of those failures are due to current julia frequently adding

    in eval at ./boot.jl:264

to the end of backtraces.

timholy added a commit that referenced this pull request Nov 9, 2015
@timholy timholy merged commit 8b2e807 into master Nov 9, 2015
@timholy timholy deleted the teh/methoderrors2 branch November 9, 2015 12:06
timholy added a commit that referenced this pull request Nov 29, 2015
(cherry picked from commit 3e7a401)
ref #13921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants