Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document newline normalization in literal strings #14078

Merged
merged 1 commit into from
Nov 21, 2015
Merged

document newline normalization in literal strings #14078

merged 1 commit into from
Nov 21, 2015

Conversation

stevengj
Copy link
Member

This documents #14073.

@stevengj stevengj added docs This change adds or pertains to documentation backport pending 0.4 strings "Strings!" labels Nov 20, 2015
@tkelman
Copy link
Contributor

tkelman commented Nov 20, 2015

Great, thanks.

@stevengj
Copy link
Member Author

The AppVeyor failure (in the parallel tests) is surely unrelated. Is there an issue for this? These intermittent failures are annoying (or worse).

Assertion failed!
Program: C:\projects\julia\usr\bin\julia.exe
File: c:/projects/julia/src/codegen.cpp, Line 946
Expression: !li->inInference

Is this #5502?

@tkelman
Copy link
Contributor

tkelman commented Nov 21, 2015

That looks like a possible culprit. Have there been gc and/or inference changes recently? That assertion failure along with a smallvector llvm assertion failure have gotten frequent within the last week or so on 32 bit, and timeouts where one of the workers freezes partway through have been happening often on 64 bit.

stevengj added a commit that referenced this pull request Nov 21, 2015
@stevengj
Merge pull request #14078 from stevengj/crlf-doc
30dd83b 
document newline normalization in literal strings
@stevengj stevengj merged commit 30dd83b into JuliaLang:master Nov 21, 2015
@stevengj stevengj deleted the crlf-doc branch November 21, 2015 19:22
tkelman
tkelman reviewed Nov 29, 2015
View reviewed changes
doc/manual/strings.rst
@@ -439,7 +439,7 @@ backslash:
julia> print("I have \$100 in my account.\n")
I have $100 in my account.

Triple-Quoted Strings Literals
Triple-Quoted String Literals
------------------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RST is picky about header underline lengths

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a fix.

stevengj added a commit that referenced this pull request Nov 29, 2015
@stevengj @tkelman
document newline normalization in literal strings (#14073)
90584a9 
(cherry picked from commit 9ac2fd5)
ref #14078
stevengj added a commit that referenced this pull request Nov 30, 2015
@stevengj
fix underline length from #14078
a7b41f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs This change adds or pertains to documentation strings "Strings!"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevengj @tkelman