Remove erroneous SparseVector early exit #14442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an optimization available here, but this isn't quite it. Fix JuliaLang#14046.
mbauman
added a commit
to mbauman/SparseVectors.jl
that referenced
this pull request
Dec 18, 2015
There is an optimization available here, but this isn't quite it. Ref JuliaLang/julia#14442.
|
LGTM. What's the test failure in the SparseVectors.jl version of this? |
|
SparseVectors.jl is only failing on 0.5; we should probably disable 0.5 support there since it's not needed. |
|
Ah cool, makes sense. On a small screen so didn't check the run too closely. Since we don't have version-dependent REQUIRE (only require SparseVectors to be installed if the package is being used on 0.4) for consumer packages of SparseVectors we may want to leave it as is (fix this bug but leave it failing on nightly and see if someone wants to fix it) for a while. |
tkelman
added a commit
that referenced
this pull request
Dec 19, 2015
Remove erroneous SparseVector early exit
|
Makes sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an optimization available here, but this isn't quite it. Fix #14046.