Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SIGBUS in the random test on ARM. #14551

Merged
merged 1 commit into from
Jan 4, 2016
Merged

Fix SIGBUS in the random test on ARM. #14551

merged 1 commit into from
Jan 4, 2016

Conversation

yuyichao
Copy link
Contributor

@yuyichao yuyichao commented Jan 3, 2016

We should be robust against non-16bytes aligned addresses but it still has to be naturally aligned.

Fix #12359

@yuyichao yuyichao added test This change adds or pertains to unit tests system:arm ARMv7 and AArch64 labels Jan 3, 2016
@yuyichao
Copy link
Contributor Author

yuyichao commented Jan 3, 2016

OSX travis failed with a network timeout during pkg test ..... Restarted.

@Keno
Copy link
Member

Keno commented Jan 3, 2016

I don't understand this issue. Why would overalignment be a problem?

@yuyichao
Copy link
Contributor Author

yuyichao commented Jan 3, 2016

Maybe I didn't explain this well. Overalignment isn't the problem and the address shift is just for keeping what this test is supposed to be testing.

The test was added in 59e752e to make sure that (AFAICT) certain random functions do not assume all the arrays to be 16bytes aligned. However, the test added create an array that is not aligned to 8bytes for Float64 which causes the bus error on ARM. This PR makes the array aligned to it's natural alignment and still makes sure that we are testing non-16bytes aligned addresses.

@yuyichao
Copy link
Contributor Author

yuyichao commented Jan 3, 2016

... sorry I realized that I forgot one line of change when copying the patch over from my test board to my laptop..... Hopefully it makes more sense now (and don't have out of bound array access.....)

@Keno
Copy link
Member

Keno commented Jan 3, 2016

Yep, carry on

We should be robust against non-16bytes aligned addresses but it still has to be naturally aligned.
@yuyichao
Copy link
Contributor Author

yuyichao commented Jan 3, 2016

And I include that in the comment now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system:arm ARMv7 and AArch64 test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants