-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SIGBUS in the random
test on ARM.
#14551
Conversation
OSX travis failed with a network timeout during pkg test ..... Restarted. |
I don't understand this issue. Why would overalignment be a problem? |
Maybe I didn't explain this well. Overalignment isn't the problem and the address shift is just for keeping what this test is supposed to be testing. The test was added in 59e752e to make sure that (AFAICT) certain |
286cbe0
to
ac1722a
Compare
... sorry I realized that I forgot one line of change when copying the patch over from my test board to my laptop..... Hopefully it makes more sense now (and don't have out of bound array access.....) |
ac1722a
to
b4bedf0
Compare
Yep, carry on |
We should be robust against non-16bytes aligned addresses but it still has to be naturally aligned.
b4bedf0
to
fd86087
Compare
And I include that in the comment now. |
Fix SIGBUS in the `random` test on ARM.
We should be robust against non-16bytes aligned addresses but it still has to be naturally aligned.
Fix #12359