Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to call uname on Windows during versioninfo(true) #14579

Merged
merged 1 commit into from
Jan 7, 2016

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Jan 7, 2016

Add a test that versioninfo(IOBuffer(), true) works

Yay, posix assumptions. mprsv also brings up memories of a past life where I spent too many months dealing with a manifold pressure regulating shutoff valve...

@vtjnash
Copy link
Member

vtjnash commented Jan 7, 2016

it would be better if you could assert some of the content is correct, but i guess this test is better than none. i think uname probably was previously getting provided by git?

@tkelman
Copy link
Contributor Author

tkelman commented Jan 7, 2016

Agreed, and correct. Any particular content we care about enough to test often? I just couldn't be bothered picking. Though it looks like the Pkg.status part of this will go and clone METADATA so we can't actually put this in test/misc.jl.

@vtjnash
Copy link
Member

vtjnash commented Jan 7, 2016

Pkg.status probably should never be a mutating operation, but perhaps that'll be a Pkg3 improvement.

I would usually just look for a bit of the structure -- something at the beginning and something at the end -- to check that it wasn't a complete no-op failure.

@tkelman
Copy link
Contributor Author

tkelman commented Jan 7, 2016

Yeah. Sounds like a good idea. For now I'll move it to test/pkg.jl because why not. I also think there might be some other copy of uname floating around on the appveyor path so this particular issue would only be noticed locally.

Add a test that versioninfo(IOBuffer(), true) works
tkelman added a commit that referenced this pull request Jan 7, 2016
Do not try to call uname on Windows during versioninfo(true)
@tkelman tkelman merged commit 9651303 into master Jan 7, 2016
@tkelman tkelman deleted the tk/versioninfo branch January 7, 2016 20:45
tkelman added a commit that referenced this pull request Jan 9, 2016
Add a test that versioninfo(IOBuffer(), true) works

(cherry picked from commit ccf716e)
ref #14579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system:windows Affects only Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants