RFC: fixes IntSet copy!(a,a) for a === a; #14581 #14582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsunberg
changed the title
|
I'm new to contributing to large projects on github, so this commit is kind of a learning experiment for me. The Travis CI 32 bit build failed with LoadError: start_watching (FileMonitor): no space left on device (ENOSPC) Is there a way for me to tell it to try again? Is it my responsibility to try to get it to work? |
|
Hi @zsunberg, I've restarted the build for you. Generally you need a project contributor to do this on Travis. Welcome to Julia! This LGTM as soon as the restarted build passes. |
|
Thanks for this! |
JeffBezanson
added a commit
that referenced
this pull request
Jan 7, 2016
RFC: fixes IntSet copy!(a,a) for a === a; #14581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an
IntSetis copied into itself, it currently erases the data. Instead the function should do nothing. See #14581