Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set JULIA_TEST_MAXRSS_MB=600 on appveyor #14845

Merged
merged 2 commits into from
Jan 29, 2016
Merged

set JULIA_TEST_MAXRSS_MB=600 on appveyor #14845

merged 2 commits into from
Jan 29, 2016

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Jan 29, 2016

in anticipation of appveyor potentially moving to 4 cores again

don't merge this until we start seeing builds happen on more cores

in anticipation of appveyor potentially moving to 4 cores again
@JeffBezanson
Copy link
Member

+1 Can we do this on travis too? I think this might help regardless of the number of cores. I suspect there are some slight super-linearities as code accumulates in the cache, and restarting more might make the tests faster overall. For example here's a small local experiment:

jeff@gurren:~/src/julia/test$ JULIA_CPU_CORES=1 ../julia runtests.jl misc
     * misc                  in  54.57 seconds, maxrss  345.02 MB

jeff@gurren:~/src/julia/test$ JULIA_CPU_CORES=1 ../julia runtests.jl core misc
     * core                  in  14.95 seconds, maxrss  212.13 MB
     * misc                  in  69.01 seconds, maxrss  393.70 MB

I picked misc since it seems to have one of the largest slowdowns after llvm 3.7.

@tkelman
Copy link
Contributor Author

tkelman commented Jan 29, 2016

Worth trying I suppose. The renumbering of restarted workers can make failures/freezes a little tough to follow which is why I'm not a huge fan of this as currently implemented.

I suspect there are some slight super-linearities as code accumulates in the cache

That's definitely another bullet to add to #14743...

and split some long lines
(hopefully the yml parsing gods don't get angered by this)
@tkelman
Copy link
Contributor Author

tkelman commented Jan 29, 2016

Yeah, this does save a few minutes. Bit better throughput is worth the slightly more confusing bookkeeping.

tkelman added a commit that referenced this pull request Jan 29, 2016
set JULIA_TEST_MAXRSS_MB=600 on appveyor
@tkelman tkelman merged commit 1f7c72e into master Jan 29, 2016
@tkelman tkelman deleted the tk/appveyormemlimit branch January 29, 2016 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants