Make doc collection 600x faster in genstdlib.jl #15177
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line takes ~0.12s on 0.4 and ~70s on master. It spends all it's time doing type inference on
string(::Function)
andadd_all_docs(_, ::Function)
(whereFunction
is a concrete gf type). This patch bring the time down to ~0.12s.@JeffBezanson Seems that some specialization heuristic is messed up here?