linspace with 1 or 0 elements is sorted #15245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -744,7 +744,7 @@ reverse(r::LinSpace) = LinSpace(r.stop, r.start, r.len, r.divisor) | |||
| ## sorting ## | |||
|
|
|||
| issorted(r::UnitRange) = true | |||
| issorted(r::Range) = step(r) >= zero(step(r)) | |||
| issorted(r::Range) = length(r) <= 1 ? true : step(r) >= zero(step(r)) | |||
There was a problem hiding this comment.
I think issorted(r::Range) = length(r) <= 1 || step(r) >= zero(step(r)) would look better.
gustafsson
force-pushed
the
short-linspace-is-sorted
branch
from
23d473d
to
32c3342
Compare
|
@pabloferz agreed |
|
+1 Looks like this causes a dates test failure? Maybe that test is invalid. |
|
Yeah. It seems that the test in dates was relying on the previous incorrect behaviour. @gustafsson Seems that you would have to remove that test. |
gustafsson
force-pushed
the
short-linspace-is-sorted
branch
3 times, most recently
from
3273b6a
to
1fba161
Compare
|
To clarify, this applies to any Range, not just linspace. For instance |
gustafsson
force-pushed
the
short-linspace-is-sorted
branch
from
1fba161
to
93accd9
Compare
|
bump, this still applies in master, any comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linspace of length 1 or 0 causes a step length of NaN which makes "issorted" return false.
I expected the same return value as the flattened data (collect of such a linspace) which has a true "issorted".