Updated zlib, gzip to work with system zlib. #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use 64-bit functions by default if available, otherwise use 32-bit functions; ZFileOffset type is set accordingly * Fix race condition in GZip.gzclose * Export GZip.readall * Make sure eof is set after read
Closed
JeffBezanson
added a commit
that referenced
this pull request
Nov 16, 2012
Updated zlib, gzip to work with system zlib.
|
Congrats, Kevin. All tests pass my 32-bit Ubuntu builds. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use 32-bit functions; ZFileOffset type is set accordingly
The main change here is testing for the existence of 64-bit functions, for which
dlsym_e()is now exported. Please let me know if there is a better way to deal with this.Edit: to clarify,
dlsym_e()avoids an error message fromdlsym()when the function in question does not exist.Thanks,
Kevin