Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #15590 #15592

Merged
merged 1 commit into from
Mar 23, 2016
Merged

fix #15590 #15592

merged 1 commit into from
Mar 23, 2016

Conversation

JeffBezanson
Copy link
Member

No description provided.

@JeffBezanson
fix #15590, vect exprs not printed right in syntax deprecations
1091c9d 
fix some other cases in `deparse` as well
@vtjnash vtjnash added the needs tests Unit tests are required for this change label Mar 23, 2016
@JeffBezanson
Copy link
Member Author

@vtjnash This is only used when printing syntax deprecation warnings. Do we have any tests for those?

@JeffBezanson JeffBezanson merged commit 29a1bcb into master Mar 23, 2016
@tkelman tkelman deleted the jb/fix15590 branch March 23, 2016 22:58
@ranjanan
Copy link
Contributor

@JeffBezanson @vtjnash This kind of syntax now throws an error

julia> [1] [2]
ERROR: syntax: space before "[" not allowed in "[1] ["

Is this PR meant to have changed the text in the warning or actually throw an error?

@tkelman
Copy link
Contributor

tkelman commented Aug 12, 2016

At the time of this PR it was a warning, a few months later it was made an error. If there are now tests for the printing of the syntax error, then we can remove the needs-tests label.

@ranjanan
Copy link
Contributor

Alright, will send a PR with tests to check for the error.

@tkelman
Copy link
Contributor

tkelman commented Aug 12, 2016

Check test/parse.jl for what's there already, might already be covered.

@ranjanan
Copy link
Contributor

I cannot find a test for this there, so I'll write one up.

ranjanan added a commit to ranjanan/julia that referenced this pull request Aug 12, 2016
@ranjanan
Write up test for JuliaLang#15592
55e016d 
parse("[1] [2]") should throw a ParseError
@ranjanan ranjanan mentioned this pull request Aug 12, 2016
Merged
JeffBezanson added a commit that referenced this pull request Aug 15, 2016
@JeffBezanson
Merge pull request #17988 from ranjanan/RA/parse
5e58247 
Write up test for #15592
@tkelman tkelman removed the needs tests Unit tests are required for this change label Aug 16, 2016
tkelman pushed a commit that referenced this pull request Aug 20, 2016
@ranjanan @tkelman
Write up test for #15592
bc19ea4 
parse("[1] [2]") should throw a ParseError

(cherry picked from commit 55e016d)
ref #17988
mfasi pushed a commit to mfasi/julia that referenced this pull request Sep 5, 2016
@ranjanan @mfasi
Write up test for JuliaLang#15592
47d192e 
parse("[1] [2]") should throw a ParseError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JeffBezanson @ranjanan @tkelman @vtjnash