Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable fastisel for -O3 #15984

Merged
merged 1 commit into from
Apr 23, 2016
Merged

Disable fastisel for -O3 #15984

merged 1 commit into from
Apr 23, 2016

Conversation

yuyichao
Copy link
Contributor

@yuyichao yuyichao commented Apr 21, 2016 •
edited
Loading

There are at least two cases where fastisel generates worse instruction (1df19b8#commitcomment-17200932 , #11592 (comment))

The downside is that we build the sysimg by with -O3 so this might make it slightly slower.

@Keno

Close #15985

@yuyichao yuyichao added the compiler:codegen Generation of LLVM IR and native code label Apr 21, 2016
@vtjnash
Copy link
Member

vtjnash commented Apr 21, 2016

lgtm

This was referenced Apr 21, 2016
Closed
Closed
@yuyichao
Copy link
Contributor Author

Travis osx failure is #15808
Appveyor win64 failure is #15993 (second numerical test failure for special random input I hit in the past few days....)

Rebased to restart the build. Hopefully this won't make #15808 worse...

@yuyichao yuyichao merged commit 1bc42ef into master Apr 23, 2016
@yuyichao yuyichao deleted the yyc/o3isel branch April 23, 2016 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
compiler:codegen Generation of LLVM IR and native code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuyichao @vtjnash