Fix PkgDev breakage in find_in_path #16020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could maybe do with a test if we can come up with something that doesn't require all of PkgDev to reproduce? thanks for getting to this |
timholy
force-pushed
the
teh/find_in_path
branch
from
534b902 to
9b0b7a7
Compare
|
Test added. |
timholy
force-pushed
the
teh/find_in_path
branch
from
9b0b7a7 to
e796f41
Compare
timholy
referenced
this pull request
in JuliaLang/PkgDev.jl
Apr 25, 2016
Fixes the following error:
```
ERROR: MethodError: no method matching find_in_path(::SubString{UTF8String}, ::ASCIIString)
Closest candidates are:
find_in_path(::Union{ASCIIString,UTF8String}, ::Any)
in dir(::SubString{UTF8String}) at /Users/kfischer/.julia/v0.5/PkgDev/src/PkgDev.jl:18
[inlined code] from ./none:69
in (::PkgDev.Entry.##4#7{ASCIIString})(::Base.LibGit2.GitRepo) at /Users/kfischer/.julia/v0.5/PkgDev/src/entry.jl:52
in with(::PkgDev.Entry.##4#7{ASCIIString}, ::Base.LibGit2.GitRepo) at ./libgit2/types.jl:565
[inlined code] from ./none:51
in publish(::ASCIIString, ::ASCIIString) at /Users/kfischer/.julia/v0.5/PkgDev/src/entry.jl:49
in publish() at /Users/kfischer/.julia/v0.5/PkgDev/src/PkgDev.jl:55
in eval(::Module, ::Any) at ./boot.jl:236
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #15934.
[edit by tkelman] closes JuliaLang/PkgDev.jl#38