PR 16150 use Symbol(x...) and deprecate symbol(x...) #16150
Conversation
| @@ -1082,6 +1082,9 @@ end | |||
| @deprecate sprand{T}(n::Integer, density::AbstractFloat, ::Type{T}) sprand(T, n, density) | |||
| @deprecate sprand{T}(r::AbstractRNG, n::Integer, density::AbstractFloat, ::Type{T}) sprand(r, T, n, density) | |||
|
|
|||
| # #16130 | |||
| @deprecated symbol Symbol | |||
There was a problem hiding this comment.
@deprecate, not @deprecated
|
Could you please try harder to force push to the branch you are working on? You can practice on a different branch with possibly a PR on your fork if you are not sure what you are doing. |
|
All the past PR's now say "unknown repository" which I think can only happen if you delete your fork. That's really not necessary. The persistence is appreciated, but please ask for help with git rather than making more of a mess with multiple PR's. |
jeffreysarnoff-dev
changed the title
|
throwing in the towel |
|
We're a couple lines away this time. One of us can take over and finish the final few lines, though that would be a sixth PR for this. Unless you'd like to give one of us collaborator access to your fork and we could reopen and finish this for you? |
|
I have fixed up a branch. Let me open a PR. |
|
It looks like all of the above comments were already addressed. |
picking up detached github branch for the automated checking (from #16130)