fix inconsistent use of strlen in jl_load #16218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
init.c
was callingjl_load("boot.jl", sizeof("boot.jl"))
, which is wrong because the second argument is supposed to be the string length, butsizeof
on a literal string is the string length + 1 to include the terminating NUL char.Also, I noticed that the
jl_parse_eval_all
function wasn't actually using thelen
parameter in one place where it could have exploited it.