Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disallow juxtaposition with literals ending in . #16339

Merged
merged 1 commit into from
May 18, 2016
Merged

Conversation

JeffBezanson
Copy link
Sponsor Member

This is likely the less-breaking part of #15731.

@vtjnash
Copy link
Sponsor Member

vtjnash commented May 18, 2016

@Keno how will the affect JuliaParser?

@vtjnash vtjnash merged commit 0645f64 into master May 18, 2016
@vtjnash vtjnash deleted the jb/dot_juxtapose branch May 18, 2016 04:57
@Keno
Copy link
Member

Keno commented May 18, 2016

We'll have to make the corresponding change there.

@PallHaraldsson
Copy link
Contributor

I was going to fix this, but can't tell why the link is missing in NEWS.. No big deal, but since the syntax seems identical, I'm puzzled..

@tkelman
Copy link
Contributor

tkelman commented May 18, 2016

Someone will have to run the news-update script in contrib to add the actual link at the bottom of the file, I think.

@JeffBezanson
Copy link
Sponsor Member Author

I've just been assuming we'll run news-update before release --- trying to avoid merge conflicts at the end of the file.

@tkelman
Copy link
Contributor

tkelman commented May 18, 2016

Yes that one is more reliably automatic and not a big deal to run long after the fact, as opposed to genstdlib which is better to run simultaneously.

@stevengj
Copy link
Member

I grepped for things that this would break in Julia packages, and all I found was 1.im and 0.im in QuantumOptics.jl (cc @bastikr). I probably missed some, but it doesn't seem like this will break a lot of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants