-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate dict comprehension syntax. fixes #16510 #16561
Conversation
There are several uses of this remaining that didn't trigger deprecation warnings but should have: Also devdocs/ast.rst needs an update (and sphinx is complaining that it's currently malformed) |
That must be due to #10727, which I don't really agree with. |
Yeah, ref #10728 (comment), and it would be more useful if the various command-line flags were available as scoped in-language API's. |
Or people who want to build deprecated syntax into userimg could manually add the flag themselves, it seems like just honoring the command line flag would be enough there. |
Yes I think we should revert that change. Never getting warnings for Base because somebody once found them annoying is the wrong tradeoff. |
see discussion in JuliaLang#16561, deprecations should be flagged, found, and removed in base - if you need to include code with deprecations in userimg.jl, then add --depwarn=no manually when building that custom image
see discussion in JuliaLang#16561, deprecations should be flagged, found, and removed in base - if you need to include code with deprecations in userimg.jl, then add --depwarn=no manually when building that custom image
I think the only reason I haven't been bitten by this is that I usually make changes first, make sure that nothing breaks and only then add deprecations. Of course, that's gotten me in trouble too. |
see discussion in JuliaLang#16561, deprecations should be flagged, found, and removed in base - if you need to include code with deprecations in userimg.jl, then add --depwarn=no manually when building that custom image
Is there compat support for this yet? I guess this will need an entry in the |
No description provided.