Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate dict comprehension syntax. fixes #16510 #16561

Merged
merged 1 commit into from
May 25, 2016

Conversation

JeffBezanson
Copy link
Member

No description provided.

@JeffBezanson JeffBezanson merged commit 2a0184d into master May 25, 2016
@tkelman tkelman deleted the jb/deprecate_dict_compr branch May 25, 2016 18:57
@tkelman
Copy link
Contributor

tkelman commented May 25, 2016

There are several uses of this remaining that didn't trigger deprecation warnings but should have:
https://gist.github.com/93bc9000984ee4b603f3839c3ace0e50

Also devdocs/ast.rst needs an update (and sphinx is complaining that it's currently malformed)

@JeffBezanson
Copy link
Member Author

That must be due to #10727, which I don't really agree with.

@tkelman
Copy link
Contributor

tkelman commented May 25, 2016

Yeah, ref #10728 (comment), and it would be more useful if the various command-line flags were available as scoped in-language API's.

@tkelman
Copy link
Contributor

tkelman commented May 25, 2016

Or people who want to build deprecated syntax into userimg could manually add the flag themselves, it seems like just honoring the command line flag would be enough there.

@JeffBezanson
Copy link
Member Author

Yes I think we should revert that change. Never getting warnings for Base because somebody once found them annoying is the wrong tradeoff.

tkelman added a commit to tkelman/julia that referenced this pull request May 25, 2016
see discussion in JuliaLang#16561, deprecations should be flagged, found, and removed
in base - if you need to include code with deprecations in userimg.jl, then
add --depwarn=no manually when building that custom image
tkelman added a commit to tkelman/julia that referenced this pull request May 25, 2016
see discussion in JuliaLang#16561, deprecations should be flagged, found, and removed
in base - if you need to include code with deprecations in userimg.jl, then
add --depwarn=no manually when building that custom image
@StefanKarpinski
Copy link
Member

I think the only reason I haven't been bitten by this is that I usually make changes first, make sure that nothing breaks and only then add deprecations. Of course, that's gotten me in trouble too.

tkelman added a commit to tkelman/julia that referenced this pull request May 25, 2016
see discussion in JuliaLang#16561, deprecations should be flagged, found, and removed
in base - if you need to include code with deprecations in userimg.jl, then
add --depwarn=no manually when building that custom image
@quinnj
Copy link
Member

quinnj commented Jun 8, 2016

Is there compat support for this yet? I guess this will need an entry in the @compat macro to change the lowering?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants