Add some tests for libgit2 and a function to list all the reference names #16728
Conversation
|
👍 |
| @@ -219,6 +219,12 @@ mktempdir() do dir | |||
| @test LibGit2.iszero(commit_oid2) | |||
| commit_oid2 = LibGit2.commit(repo, commit_msg2; author=test_sig, committer=test_sig) | |||
| @test !LibGit2.iszero(commit_oid2) | |||
| auths = LibGit2.authors(repo) | |||
| for auth in auths | |||
There was a problem hiding this comment.
how many should there be in this test case?
|
@tkelman this good to go? |
| @@ -219,6 +219,13 @@ mktempdir() do dir | |||
| @test LibGit2.iszero(commit_oid2) | |||
| commit_oid2 = LibGit2.commit(repo, commit_msg2; author=test_sig, committer=test_sig) | |||
| @test !LibGit2.iszero(commit_oid2) | |||
| auths = LibGit2.authors(repo) | |||
| @test length(auths) == 3 | |||
There was a problem hiding this comment.
which repo is this, is it constructed from scratch in this test harness, or is it referring to something like Example.jl that may change over time?
There was a problem hiding this comment.
Pretty sure it's from scratch
On Jun 3, 2016 10:43 AM, "Tony Kelman" notifications@github.com wrote:
In test/libgit2.jl
#16728 (comment):@@ -219,6 +219,13 @@ mktempdir() do dir
@test LibGit2.iszero(commit_oid2)
commit_oid2 = LibGit2.commit(repo, commit_msg2; author=test_sig, committer=test_sig)
@test !LibGit2.iszero(commit_oid2)
auths = LibGit2.authors(repo)@test length(auths) == 3which repo is this, is it constructed from scratch in this test harness,
or is it referring to something like Example.jl that may change over time?—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JuliaLang/julia/pull/16728/files/4761fc6757a8ce5b5d8a049737ca7bc2a0293976#r65747279,
or mute the thread
https://github.com/notifications/unsubscribe/AAyk452oBDr8VRy17iIXaMEOESjv-t9eks5qIGejgaJpZM4Is-63
.
| return oid_ptr[] | ||
| oid_ptr = ccall((:git_tag_target_id, :libgit2), Ptr{Oid}, (Ptr{Void}, ), tag.ptr) | ||
| oid_ptr == C_NULL && throw(Error.GitError(Error.ERROR)) | ||
| return Oid(oid_ptr) |
There was a problem hiding this comment.
Oh in this case the Oid constructor actually does check and throw for null pointers already.
Just so I'm clear, the old code was returning a Ptr{Oid} from the ccall, wrapping that in a Ref then dereferencing the Ref - what type was that returning, a Ptr{Oid} or an Oid?
edit: nevermind I was looking at the wrong Oid constructor, the Oid(ptr::Ptr{Oid}) just does unsafe_load(ptr)::Oid so leave the null check.
There was a problem hiding this comment.
That should return an Oid, I think. @wildart ?
There was a problem hiding this comment.
OK, I never used this function, but I'm pretty sure that it should return Oid. My implementation was wrong.
cc @wildart