Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce MAX_TUPLETYPE_LEN #16734

Merged
merged 1 commit into from
Jun 3, 2016
Merged

reduce MAX_TUPLETYPE_LEN #16734

merged 1 commit into from
Jun 3, 2016

Conversation

JeffBezanson
Copy link
Member

A less ambitious version of #16628. The overhead of this in the compiler is quite significant, and not really worth the tradeoff of better-performing 42-dimensional arrays. This parameter controls how far inference will follow recursion, so for example a recursive variadic function might be analyzed 42 times. Eventually we will need a smarter, more surgical fix for this issue, so that we can specialize code for high-dimensional arrays while still avoiding non-termination.

@timholy
Copy link
Member

timholy commented Jun 3, 2016

👍 Thanks for the eagle eye here in terms of performance implications.

@JeffBezanson JeffBezanson merged commit 3f59431 into master Jun 3, 2016
@tkelman tkelman deleted the jb/tuple_limit branch June 3, 2016 17:32
@andyferris
Copy link
Member

@JeffBezanson +1 for eventually thinking about a "smarter, more surgical fix". I've been wondering if these parameters may one-day be controlled with a :meta expression or similar on a per-method, per-instruction or per-type basis? Similar to @inbounds and @inline, but something like @infer_the_crap_out_of_this (joking).

My current case of interest is TypedTables.jl where it's difficult to get great code-gen for tables with more than 8 columns (or is it 42, or 16? 😛 ). I'm currently trying to get a better understanding of inference.jl and although I have gained quite a lot of insight on matching my experimentation with the magic of inference and constant propagation, I'm still having trouble seeing how it all comes together (so that I might perhaps contribute one day).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants