Lazy initialize gmp and mpfr finalizers #17010
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cglobal
is done at codegen time not runtime so there's no need to use a global variable for these.This also make the
finalizer
call type stable and makes construction ofBigFloat
andBigInt
5-20% faster.This will cause a minor behavioral change when the symbol can't be found. In the old version, it would print an warning at init time and silently ignore the error at runtime, In the new version, it will raise a runtime error.
Given that all of these are only in
try-catch
after #12742, I assume we don't support a version of gmp that doesn't have these symbols and a runtime error should be better (if it is at all possible to have the init symbol but not the clear symbol....).